Add unit tests for org.fengfei.lanproxy.common.LangUtil#120
Open
ThomasPerkins1123 wants to merge 1 commit intoffay:masterfrom
Open
Add unit tests for org.fengfei.lanproxy.common.LangUtil#120ThomasPerkins1123 wants to merge 1 commit intoffay:masterfrom
ThomasPerkins1123 wants to merge 1 commit intoffay:masterfrom
Conversation
These tests were written using Diffblue Cover.
Author
|
Hi, just following up and wondering if you would like me to make any changes to the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've analysed your code base and noticed that
org.fengfei.lanproxy.common.LangUtilin thelanproxymodule is not fully tested.I've written some tests that cover this class using Diffblue Cover.
Hopefully, these tests should help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be more than happy to look at other particular classes that you consider important.